Fix bug in value attributes #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsargent
commented
Apr 15, 2024
| return builder.toString(); | ||
| } | ||
|
|
||
| // if the field has elided, tostringvalue, abbreviateafter, or ascardinal, | ||
| // it should apply to the value instead. | ||
| Attributes collectValueAttributes(Attributes fa, Attributes valueAttributes) { |
There was a problem hiding this comment.
Add a fallback for fields that have attributes set on them that really only apply to the value.
wsargent
commented
Apr 15, 2024
| @@ -28,10 +28,26 @@ public String formatField(@NotNull Field field) { | |||
| assert fieldVisitor != null; | |||
| field = fieldVisitor.visit(field); | |||
| } | |||
| formatValue(builder, field.value(), attributes); | |||
There was a problem hiding this comment.
should be using the value's attributes, not the field's attributes
wsargent
commented
Apr 15, 2024
| @@ -135,7 +151,7 @@ private void formatObject(@NotNull StringBuilder b, @NotNull Value.ObjectValue v | |||
| assert fieldVisitor != null; | |||
| field = fieldVisitor.visit(field); | |||
| } | |||
| formatValue(b, field.value(), attributes); | |||
| formatValue(b, field.value(), field.value().attributes()); | |||
There was a problem hiding this comment.
Use the value's attributes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.